Skip to content

Move VarBin UTF-8 validation out of type dispatch - #11607

Merged
connortsui20 merged 1 commit into
developfrom
ct/varbin-utf8-dispatch
Nov 18, 2026
Merged

connortsui20 merged 1 commit into
developfrom
ct/varbin-utf8-dispatch

Conversation

@connortsui20

@connortsui20 connortsui20 commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

cargo-mutants skips macro bodies, which hides VarBin’s choice between validating the whole byte range and checking non-null strings individually. A generic helper exposes that decision and the per-string loop to mutation testing.

Follow-up to #11605.
Stacked on #11606.

Prepared and opened with Codex.

@connortsui20 connortsui20 added the changelog/chore A trivial change label Nov 18, 2026 — with ChatGPT Codex Connector
@connortsui20 connortsui20 self-assigned this Nov 18, 2026
@connortsui20
connortsui20 enabled stacked auto-merge (squash) November 18, 2026 19:03
@connortsui20
connortsui20 force-pushed the ct/varbin-utf8-dispatch branch from 805ece9 to b73bd90 Compare November 18, 2026 19:04
@connortsui20
connortsui20 disabled stacked auto-merge November 18, 2026 19:04
@connortsui20
connortsui20 changed the base branch from develop to ct/delta-probe-dispatch November 18, 2026 19:04
Base automatically changed from ct/delta-probe-dispatch to develop November 18, 2026 19:39
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20
connortsui20 force-pushed the ct/varbin-utf8-dispatch branch from b73bd90 to c4d23b9 Compare November 18, 2026 19:39
@connortsui20
connortsui20 enabled stacked auto-merge (squash) November 18, 2026 19:39
@codspeed

codspeed Bot commented Nov 18, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 35.39%

1 warning

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 1973 untouched benchmarks
⏩ 53 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ CPU Simulation ArrowExportVTable_to_arrow_field 16.8 µs 44.4 µs -62.15%
⚡ Walltime decode_avx512[DeltaU8] 11 µs 10 µs +10.3%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ct/varbin-utf8-dispatch (c4d23b9) with develop (b986307)

Open in CodSpeed

Footnotes

  1. 53 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

stacked auto-merge was automatically disabled November 18, 2026 20:21

Auto-merge was disabled for another pull request in the stack

@connortsui20
connortsui20 merged commit 972dbb7 into develop Nov 18, 2026
73 of 74 checks passed
@connortsui20
connortsui20 deleted the ct/varbin-utf8-dispatch branch November 18, 2026 20:22
connortsui20 added a commit that referenced this pull request Nov 18, 2026
`cargo-mutants` skips macro bodies, which hides the choice between
chunked and flat patch searches. Generic helpers expose that decision
and the flat search’s offset handling to mutation testing.

Follow-up to #11605.
Stacked on #11607.

Prepared and opened with Codex.

Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants